Prevent DoS attacks by rejecting unknown realms#594
Merged
adutra merged 1 commit intoapache:mainfrom Jan 14, 2025
Merged
Conversation
1 task
adutra
force-pushed
the
realms-configuration
branch
15 times, most recently
from
14c5f45 to
f2b0110
Compare
adutra
force-pushed
the
realms-configuration
branch
7 times, most recently
from
61a33c8 to
d2fb2d5
Compare
adutra
force-pushed
the
realms-configuration
branch
from
d2fb2d5 to
57fc8cb
Compare
adutra
changed the title
adutra
requested review from
ashvina,
dimas-b and
eric-maynard
as code owners
adutra
requested review from
RussellSpitzer,
collado-mike,
ebyhr,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
Contributor
Author
|
Ready for review. |
snazy
reviewed
Jan 14, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
I think this change is fine to fix at least the possible DoS attack.
We can always make the realm-resolution dynamic later.
snazy
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now ready for review.
This PR fixes #541 by preventing unknown realms to proceed.
It's probably not the definitive way of declaring realms, but given that we don't have an API yet to manage realms, the best solution is to declare known realms upfront in the configuration.
This PR also introduces a
TestRealmContextResolverthat is basically the old realm context resolver, and which is used in tests only.